Messages

181

Archived Proposals / Re: Iquidus Explorer: upgrade to support GETUTXO in API

« on: April 13, 2018, 02:17:04 AM »

Proposal created. Kindly consider to vote for this proposal, included in this month IT budget, if you find it interesting:

gobject vote-many 03aa25b80bf951bcaaed1589a52c8cd8cf58893912df176c2b4bafef47d90296 funding yes

Thenk you

182

Archived Proposals / Re: Iquidus Explorer: upgrade to support GETUTXO in API

« on: April 12, 2018, 01:19:33 PM »

Plan B seemed to work. It's about maintaining a clear list of the address UTXOs.

It takes a bit more database space and longer to index (about twice the time) but the good point is that calling the getutxo API is 5 times faster than the other way. I don't expect the other queries to be affected.

As soon as I can contact Lichtsucher we will try to test it on a test environment.

183

Archived Proposals / Re: Iquidus Explorer: upgrade to support GETUTXO in API

« on: April 12, 2018, 10:07:59 AM »

Ok I tried to add outpoint info in inputs so with a simple query you could know if it's unspent or not.

However, there was a trap:  Iquidus explorer iterates through all transaction inputs, but doesn't record all of them, it creates only one per address and then accumulates the amounts over the same "virtual" input.  This is logical as it is what we expect to see in the user interface.

So my initial approach can't work.

My "plan B" approach is, when processing inputs, trying to recover back the original output  and "mark" it as spent, then save again.  It way harder to implement, but probably the only way to go without changing the database model drastically.

 

184

Archived Proposals / Iquidus Explorer: upgrade to support GETUTXO in API

« on: April 11, 2018, 02:04:23 PM »

We need Iquidus explorer to support GETUTXO in its API.

It's required to support the paper wallet sweep in mobile versions. I expected Breadwallet to support this via some SPV functionality but it was not the case.

SCOPE OF WORK

- Starting from current Iquidus Explorer master version, implement GETUTXO in explorer API

http://explorer.biblepay-central.org/ext/getutxos/{address}

Output format will be recognized by Biblepay mobile wallet.
(see sample in https://api.breadwallet.com/q/addr/3PauLgPVQu2r6QnvWvK1GDGXdeB3ouCdqw/utxo?currency=BTC)


TASK BREAKDOWN

- Fork Iquidus explorer project, install biblepaycore, install explorer on a dev ubuntu computer (2h)
- Change database load to store outpoint hash and index in transaction inputs (2h)
- Implement check_is_unspent as a query to know if an output has already been used (1h)
- Implement API route /ext/getutxos (2h)
- Explorer full load tests (2h)

Total Budget:
9h dev&test @40€/h = 360€
= 0,064285 BTC (@ 5600€) = 173745 BBP (@37 sat)

Work is very advanced, and it works pretty fast. It will be a nice addition that few coin explorers have.

All code will be open sourced.

I will need Lichtsucher's help to update biblepay-central explorer. I don't know if you have a test environment before we go live.
A full reindex of the database will be required so expect a few hours downtime.

185

Archived Proposals / Re: BiblePay mobile wallet (Android & iOS)

« on: April 10, 2018, 12:32:54 PM »

MIP you are awesome for jumping on this!

Is the code open source?

Sure. But at the moment it's on dev branch. As soon as we go real I'll push it to master and probably we'll move it to biblepay github repository.

186

Archived Proposals / Re: BiblePay mobile wallet (Android & iOS)

« on: April 10, 2018, 10:12:17 AM »

Some quick updates:

I can't contact with Breadwallet devs asking about iOS repository updates. I'll wait a few days more.

Regarding Iquidus explorer, I will have to tweak the original node.js code so the transaction inputs can include the OutPoint info, which is required to implement a getUtxos API.
Of course after this update the explorer database will have to be rebuilt from scratch but well,.. that's progress. 

187

Archived Proposals / Re: BiblePay mobile wallet (Android & iOS)

« on: April 09, 2018, 08:02:17 AM »

So you have to redo a lot of work for the iOS version? If you spend more hours than expected, just put in another proposal. You've got my vote

I will try to make a full research first, before making a decision, as the changes include a refactoring of the ChainParameters data.

To make things harder, Breadwallet iOS team has not commited changes to Github since January 4th (last version is build 202 and "real" version you get from App Store is build 250) so there is a good chance that all the legwork I have to do on iOS build 202, has already been implemented by them in the last 3 months somewhere between build 202 and 250.

It would be a bit silly to throw tens of hours at the effort and see one day that it's already there when an official commit is finally made. There is no way to know until that day comes.

I will contact with Breadwallet team and ask but I don't know how jealous they are, regarding their codebase.  Another option is waiting a couple weeks and see if they finally update the repository.

What I will likely need to turn into a proposal, is the implementation of a "getutxo" API in Iquidus Explorer. It will be absolutely necessary to have the "private key sweep" feature. Breadwallet has it's own, but it's hosted on their servers and it's Bitcoin only.

188

Archived Proposals / Re: BiblePay mobile wallet (Android & iOS)

« on: April 09, 2018, 02:38:36 AM »

Wooohoooo the current Breadwallet iOS version is relying in a 5-month old branch of the SPV client library... not the one I modified for the Android compile.

This is gonna be more painful than expected   .

189

Archived Proposals / Re: BiblePay mobile wallet (Android & iOS)

« on: April 08, 2018, 01:24:59 AM »

CoinMarketCap does this automatically and the advantage is that they display a more accurate average price because they take into account the volume per exchange! So for example if exchange 1 has a 30 sat price at 99% of total volume, and exchange 2 has a 36 sat price at 1% of total volume, they will show 30 as average, not 33.

Here is their API for BBP: https://api.coinmarketcap.com/v1/ticker/biblepay/

Another advantage for you is that you will not have to update your code when new exchanges list BiblePay.

Included in the new version. Thanks for the suggestion.

190

TestNet Discussion Archive / Re: Android mobile wallet - TEST

« on: April 08, 2018, 01:21:19 AM »

OK, tested and looks that it is OK
Sharing without problem.
Sum is now in BBP, not in Bits, thats great, but the symbol isnt good.
I dont know if it is my problem or common.

Fixed

And I have other problem. When I open wallet after longer time it open first Android Authentification required screen with "please unlock your android device to continue" message. Only then it opens your wallet and ask for fingerprint unlock. I think that it is problem with some kind of way to fingerprint access.

Breadwallet requires PIN to get the wallet data from the hardware-encrypted storage. After that, if you had enabled fingerprint access for the wallet, you will have to do this step too.

I didn't touch that part at all from the original code so it sounds like normal behaviour.

I also changed price rate from Coinmarketcap as suggested in the Production Proposal thread.

APK link is the same.

191

Archived Proposals / Re: BiblePay mobile wallet (Android & iOS)

« on: April 07, 2018, 08:14:05 AM »

Finally GETUTXOS is not implemented in Biblepy Core peers (or it's disabled at the moment)  we will have to implement sweep feature using block explorer API. As Iquidus is not supporting it we will do it ourserves.

Litch could you please tell me where your Biblepay explorer source code is so I can make the changes?

Thank you!

192

Archived Proposals / Re: BiblePay mobile wallet (Android & iOS)

« on: April 07, 2018, 03:11:36 AM »

Rob or someone managing the website, Google play requires a privacy notice link in order to allow using the camera. I can "clone" the breadwallet one, but I would need to publish it in some page at biblepay.org.

Please tell me how to send you the page for publishing.

See https://breadapp.com/privacy-policy/

I created the featured image myself

193

TestNet Discussion Archive / Re: Android mobile wallet - TEST

« on: April 07, 2018, 03:10:51 AM »

I have found only one problem, when I was trying to share receiving address by email or text message wallet crashed.

Fixed, it was trying to save the QR bitmap into com.breadwallet storage, it should be com.biblepaywallet for our app.

I refreshed the APK file (uninstall the previous app and use the same dropbox link)

194

TestNet Discussion Archive / Re: Android mobile wallet - TEST

« on: April 06, 2018, 03:08:21 PM »

MIP, it will be problem to post apk on any other server?
More people has problem with download.
I have no problem with sharing it, but I think, that share from you is better

I guess you can publish it elsewhere. I will try to publish it (as beta) in Google Play, if I finish the paperwork, this weekend.

Google play asks for a featured image, I can improvise myself but if there is someone here good at graphic design, any help would be appreciated.

Some examples:

https://incipia.co/post/app-marketing/google-play-feature-graphic-ideas/

195

TestNet Discussion Archive / Re: Android mobile wallet - TEST

« on: April 06, 2018, 09:40:09 AM »

Is it possible to set the default to BBP instead of Bits? I think that would be more in line with the PC wallet.

Sure, done in dev already.