News:

F7000 COMING SOON!

Main Menu

Testnet - Test Proof of Giving

Started by Rob Andrews, December 06, 2018, 01:00:46 PM

Previous topic - Next topic

Rob Andrews

1.1.6.8 - Mandatory Upgrade (TestNet)
** Note: This mandatory will only disconnect old versions, but will not hard fork so as to keep the chain running smoother
** Forensically we now have more specific logging with the version in the POG message


- Fixed crash bug


MIP

Quote from: Rob Andrews on December 17, 2018, 03:33:42 PM
1.1.6.8 - Mandatory Upgrade (TestNet)
** Note: This mandatory will only disconnect old versions, but will not hard fork so as to keep the chain running smoother
** Forensically we now have more specific logging with the version in the POG message


- Fixed crash bug

Also available as Linux PPAs and for MacOS.

mint

Are biblepay-cli.exe and biblepayd.exe supposed to work correctly?
I have a feeling that some tithes are not working as I think.
For example if I take max amount from exec titheinfo and then run exec tithe <max>. I can see from debug.log that tithe was illegal.
What happens those bbp? Why max is illegal?

Rob Andrews

#93
Quote from: mint on December 18, 2018, 01:36:06 PM
Are biblepay-cli.exe and biblepayd.exe supposed to work correctly?
I have a feeling that some tithes are not working as I think.
For example if I take max amount from exec titheinfo and then run exec tithe <max>. I can see from debug.log that tithe was illegal.
What happens those bbp? Why max is illegal?

These might not be your tithes; Ive been trying to break it - the log is actually a log of everyones activity.

So I just tried it and mine was legal;

Could you please try it again and copy the txid, then type

exec istithelegal txid

After a couple blocks later, and that should show if it was truly illegal or legal.  Also in the log you should not see your amount (or block #).

PS: To answer about where the tithe went, yes, the tithe would have actually gone to the foundation and have been spent; so yes it is critical to ensure we verify this bug does not exist.

Ive been monitoring for PogRecipientsInvalid, and to my happiness that appears to be fixed; and the Illegal Tithes from today "should" have been mine.

Lets try to break it.


EDIT:  You should be able to go back in your txlist for the one you sent at the time of the post, and grab the txid and lets double check that one.

'exec istithelegal txid'




mint

Quote from: Rob Andrews on December 18, 2018, 05:45:17 PM
These might not be your tithes; Ive been trying to break it - the log is actually a log of everyones activity.

So I just tried it and mine was legal;

Could you please try it again and copy the txid, then type

exec istithelegal txid

After a couple blocks later, and that should show if it was truly illegal or legal.  Also in the log you should not see your amount (or block #).

PS: To answer about where the tithe went, yes, the tithe would have actually gone to the foundation and have been spent; so yes it is critical to ensure we verify this bug does not exist.

Ive been monitoring for PogRecipientsInvalid, and to my happiness that appears to be fixed; and the Illegal Tithes from today "should" have been mine.

Lets try to break it.


EDIT:  You should be able to go back in your txlist for the one you sent at the time of the post, and grab the txid and lets double check that one.

'exec istithelegal txid'
Result of this command.


exec istithelegal 61dac23991ea43d16f999cc9478a624b9a43296f896592f99309cc074ad71fe1

{
  "Command": "istithelegal",
  "Tithe_Legal": false,
  "Tithe_Age": 0.8905555555555555,
  "Tithe_Spent_Coin_Amount": 4634,
  "Tithe_Amount": 275,
  "Block_diff_min_coin_age": 5.13,
  "Block_diff_min_coin_amt": 2139,
  "Block_diff_max_tithe_amt": 274,
  "Tithed_Height": 90815
}


It took a while to find legal tithe.


exec istithelegal  cf5395b381fe371d0e418b51014299c0791df6911bd7bf1d5702afe540b1d704

{
  "Command": "istithelegal",
  "Tithe_Legal": true,
  "Tithe_Age": 6.50332175925926,
  "Tithe_Spent_Coin_Amount": 4927,
  "Tithe_Amount": 294,
  "Block_diff_min_coin_age": 0.76,
  "Block_diff_min_coin_amt": 319,
  "Block_diff_max_tithe_amt": 296,
  "Tithed_Height": 89920
}


Now I'm out of aged coins.
It looks like that it is possible to tithe from commandline client illegal tithes

mint

Why did this wallet get POG rewards?

"Confirmed","Date","Type","Label","Address","Amount (tBiblepay)","ID"
"false","2018-12-19T10:14:08","Mined","","yW8TrtjNKAAvxh5z2yqYJGiDMdnTvGC8yz","485.50457678","b9256094d79e3c15c2aaa9fea17c31f79ca962113b82c57d2e231d49e1a353a9-000"
"false","2018-12-19T10:07:05","Mined","","yW8TrtjNKAAvxh5z2yqYJGiDMdnTvGC8yz","4854.80305666","a2ce916f12ffc3ef038c9e31e197eb40b4b3199e7f5e25490631691c94f2d109-000"
"true","2018-12-18T23:36:33","Mined","","yeA8AZunKHTPUQD4Dibe1MeVFbomg1U7Qc","485.38318243","45219e8ca515f77560d821b3e119eff1b0dc80d4011acf9887d477d56b57c693-000"
"true","2018-12-18T23:34:17","Mined","","yeA8AZunKHTPUQD4Dibe1MeVFbomg1U7Qc","485.43174017","1dd063ec8243f52d8a04c22a4b0fd39c57711fcb3805e1d7efc3616474424aba-000"
"true","2018-12-18T23:30:24","Mined","","yeA8AZunKHTPUQD4Dibe1MeVFbomg1U7Qc","485.48030567","f1541dfab2c02e169bad57a34b2e9f5ddb3784e077e74ca5d39cd38467c0916a-000"
"true","2018-12-18T23:23:07","POG Reward","","yeA8AZunKHTPUQD4Dibe1MeVFbomg1U7Qc","97.09605959","085dc568b321102faa15c3269fa66fa4de84edade402f52026a64168890103cc-000"
"true","2018-12-18T23:17:45","Mined","","yeA8AZunKHTPUQD4Dibe1MeVFbomg1U7Qc","485.52886271","99a8779cd51518a8f3c63fff4e76e445165a9dfbf4b60a44940d78d74e75d547-000"
"true","2018-12-18T23:17:28","Mined","","yeA8AZunKHTPUQD4Dibe1MeVFbomg1U7Qc","485.52885565","d57eeff95645d26559469d49e2b76cbea2e2e98e5bd727d79adf9b229a936874-000"
"true","2018-12-18T23:00:42","POG Reward","","yeA8AZunKHTPUQD4Dibe1MeVFbomg1U7Qc","97.06693200","4e6c7909383f9f4156974cac9be833decfc1b2d0571a27843240a949eb5e5baa-000"
"true","2018-12-18T22:54:49","Mined","","yeA8AZunKHTPUQD4Dibe1MeVFbomg1U7Qc","485.38318243","c99c37942b2298aa675339b6570486dc9750e382412952f2fd22beadeef90417-000"
"true","2018-12-18T22:44:39","Mined","","yeA8AZunKHTPUQD4Dibe1MeVFbomg1U7Qc","485.50457678","a20ef209138ba63c15a0fe4cb6c24a14ace68c89f87796b59379bde09adb45e5-000"
"true","2018-12-18T22:38:43","Mined","","yeA8AZunKHTPUQD4Dibe1MeVFbomg1U7Qc","485.45604228","7df4ea97f8c37091667a61dc96c323957f14c5598a01ad8860227a28ba786344-000"
"true","2018-12-18T22:19:22","Mined","","yeA8AZunKHTPUQD4Dibe1MeVFbomg1U7Qc","485.43174017","9b6a9bea9cdee042da3c5198114a0aa4b8f0668d2e68b241d156649a24fb76d5-000"
"true","2018-12-18T22:15:22","Mined","","yeA8AZunKHTPUQD4Dibe1MeVFbomg1U7Qc","4855.28855647","08e6dbcdc9c6055816ba1832b449a304611a82f154e7240daedcc1db049f76d1-000"
"true","2018-12-18T22:14:42","Mined","","yeA8AZunKHTPUQD4Dibe1MeVFbomg1U7Qc","485.50457678","1bfd91d5a2aaeb5676ef1d73ebff7c418ed1c4860d93ed67bb65da3e23409b5b-000"
"true","2018-12-18T21:58:28","Mined","","yeA8AZunKHTPUQD4Dibe1MeVFbomg1U7Qc","4854.07461294","571544886393109ed674ad4bc972fbdc5d38b45f71c6081c5740372de6c13068-000"
"true","2018-12-18T21:49:14","Mined","","yeA8AZunKHTPUQD4Dibe1MeVFbomg1U7Qc","485.45601904","ae36f2d9f75cd028f8951caf739e0fa975093b25fe5f64a24ad6f02f690b8278-000"
"true","2018-12-18T21:48:45","Mined","","yeA8AZunKHTPUQD4Dibe1MeVFbomg1U7Qc","485.40746130","14e9f71c3b97766bed06446b3432857c6d3485ca8aafa6650362161eb7b228e5-000"
"true","2018-12-18T21:23:10","Mined","","yeA8AZunKHTPUQD4Dibe1MeVFbomg1U7Qc","485.40746130","2a1083542b1eea9620a95112780ee29072d26a1702ef895f2a4283409d0a535b-000"
"true","2018-12-18T21:22:01","Received with","","ydmznuZ1cHvCSnSLZ9pZg8Tgou8Ar2XjTW","10000.00000000","7c52dfa77116a625bb915df17bdb21628b4d58b447ec1b694f7a2446cb0f56a4-000"

klondike

my config:
addnode=explorer.biblepay.org
testnet=1
genproclimit=1
nickname=slovakia


still running prod, no testnet ... where is problem? after installation v168 i have this problem with testnet wallet  :(

thanks for help

Rob Andrews

#97
Quote from: klondike on December 19, 2018, 07:43:38 AM
my config:
addnode=explorer.biblepay.org
testnet=1
genproclimit=1
nickname=slovakia


still running prod, no testnet ... where is problem? after installation v168 i have this problem with testnet wallet  :(

thanks for help

EDIT:  If your wallet is booting in prod mode do this:

./biblepay-qt -conf=biblepaytest.conf

Save your testnet config file as biblepaytest.conf in the ~/.biblepaycore directory.

EDIT: Dont forget to add your tithe parameter.

Rob Andrews

Quote from: mint on December 19, 2018, 02:31:17 AM
Why did this wallet get POG rewards?

"Confirmed","Date","Type","Label","Address","Amount (tBiblepay)","ID"
"false","2018-12-19T10:14:08","Mined","","yW8TrtjNKAAvxh5z2yqYJGiDMdnTvGC8yz","485.50457678","b9256094d79e3c15c2aaa9fea17c31f79ca962113b82c57d2e231d49e1a353a9-000"
"false","2018-12-19T10:07:05","Mined","","yW8TrtjNKAAvxh5z2yqYJGiDMdnTvGC8yz","4854.80305666","a2ce916f12ffc3ef038c9e31e197eb40b4b3199e7f5e25490631691c94f2d109-000"
"true","2018-12-18T23:36:33","Mined","","yeA8AZunKHTPUQD4Dibe1MeVFbomg1U7Qc","485.38318243","45219e8ca515f77560d821b3e119eff1b0dc80d4011acf9887d477d56b57c693-000"
"true","2018-12-18T23:34:17","Mined","","yeA8AZunKHTPUQD4Dibe1MeVFbomg1U7Qc","485.43174017","1dd063ec8243f52d8a04c22a4b0fd39c57711fcb3805e1d7efc3616474424aba-000"
"true","2018-12-18T23:30:24","Mined","","yeA8AZunKHTPUQD4Dibe1MeVFbomg1U7Qc","485.48030567","f1541dfab2c02e169bad57a34b2e9f5ddb3784e077e74ca5d39cd38467c0916a-000"
"true","2018-12-18T23:23:07","POG Reward","","yeA8AZunKHTPUQD4Dibe1MeVFbomg1U7Qc","97.09605959","085dc568b321102faa15c3269fa66fa4de84edade402f52026a64168890103cc-000"
"true","2018-12-18T23:17:45","Mined","","yeA8AZunKHTPUQD4Dibe1MeVFbomg1U7Qc","485.52886271","99a8779cd51518a8f3c63fff4e76e445165a9dfbf4b60a44940d78d74e75d547-000"
"true","2018-12-18T23:17:28","Mined","","yeA8AZunKHTPUQD4Dibe1MeVFbomg1U7Qc","485.52885565","d57eeff95645d26559469d49e2b76cbea2e2e98e5bd727d79adf9b229a936874-000"
"true","2018-12-18T23:00:42","POG Reward","","yeA8AZunKHTPUQD4Dibe1MeVFbomg1U7Qc","97.06693200","4e6c7909383f9f4156974cac9be833decfc1b2d0571a27843240a949eb5e5baa-000"
"true","2018-12-18T22:54:49","Mined","","yeA8AZunKHTPUQD4Dibe1MeVFbomg1U7Qc","485.38318243","c99c37942b2298aa675339b6570486dc9750e382412952f2fd22beadeef90417-000"
"true","2018-12-18T22:44:39","Mined","","yeA8AZunKHTPUQD4Dibe1MeVFbomg1U7Qc","485.50457678","a20ef209138ba63c15a0fe4cb6c24a14ace68c89f87796b59379bde09adb45e5-000"
"true","2018-12-18T22:38:43","Mined","","yeA8AZunKHTPUQD4Dibe1MeVFbomg1U7Qc","485.45604228","7df4ea97f8c37091667a61dc96c323957f14c5598a01ad8860227a28ba786344-000"
"true","2018-12-18T22:19:22","Mined","","yeA8AZunKHTPUQD4Dibe1MeVFbomg1U7Qc","485.43174017","9b6a9bea9cdee042da3c5198114a0aa4b8f0668d2e68b241d156649a24fb76d5-000"
"true","2018-12-18T22:15:22","Mined","","yeA8AZunKHTPUQD4Dibe1MeVFbomg1U7Qc","4855.28855647","08e6dbcdc9c6055816ba1832b449a304611a82f154e7240daedcc1db049f76d1-000"
"true","2018-12-18T22:14:42","Mined","","yeA8AZunKHTPUQD4Dibe1MeVFbomg1U7Qc","485.50457678","1bfd91d5a2aaeb5676ef1d73ebff7c418ed1c4860d93ed67bb65da3e23409b5b-000"
"true","2018-12-18T21:58:28","Mined","","yeA8AZunKHTPUQD4Dibe1MeVFbomg1U7Qc","4854.07461294","571544886393109ed674ad4bc972fbdc5d38b45f71c6081c5740372de6c13068-000"
"true","2018-12-18T21:49:14","Mined","","yeA8AZunKHTPUQD4Dibe1MeVFbomg1U7Qc","485.45601904","ae36f2d9f75cd028f8951caf739e0fa975093b25fe5f64a24ad6f02f690b8278-000"
"true","2018-12-18T21:48:45","Mined","","yeA8AZunKHTPUQD4Dibe1MeVFbomg1U7Qc","485.40746130","14e9f71c3b97766bed06446b3432857c6d3485ca8aafa6650362161eb7b228e5-000"
"true","2018-12-18T21:23:10","Mined","","yeA8AZunKHTPUQD4Dibe1MeVFbomg1U7Qc","485.40746130","2a1083542b1eea9620a95112780ee29072d26a1702ef895f2a4283409d0a535b-000"
"true","2018-12-18T21:22:01","Received with","","ydmznuZ1cHvCSnSLZ9pZg8Tgou8Ar2XjTW","10000.00000000","7c52dfa77116a625bb915df17bdb21628b4d58b447ec1b694f7a2446cb0f56a4-000"


Thanks for the example.  On a side note we have a feature in the next version that will allow you to type exec pogpool height, and diagnose some of this , although that feature is broken right now in your version.  But anyway looking at your wallet and its rewards, you received the first POG reward on block 91097 for 97.09 bbp. 

So here is what happened:  Those two pog rewards are incorrectly listed as POG reward on the UI.  They are actually mining rewards.  If you look at the actual transaction, the 97.09 was the reaper reward for solving the block .

So I see the bug, and its being fixed now (as far as the display issue).  Please double check in the next version that we killed it - those two should change to Mining rewards when you boot the next version.



Rob Andrews

Quote from: thesnat21 on December 19, 2018, 12:19:13 PM
This same thing happens when the miner wins the PODC superblock,  maybe an easy fix?

Yes, exactly!  Fixed.


Rob Andrews

Quote from: mint on December 19, 2018, 02:22:32 AM
Result of this command.


exec istithelegal 61dac23991ea43d16f999cc9478a624b9a43296f896592f99309cc074ad71fe1

{
  "Command": "istithelegal",
  "Tithe_Legal": false,
  "Tithe_Age": 0.8905555555555555,
  "Tithe_Spent_Coin_Amount": 4634,
  "Tithe_Amount": 275,
  "Block_diff_min_coin_age": 5.13,
  "Block_diff_min_coin_amt": 2139,
  "Block_diff_max_tithe_amt": 274,
  "Tithed_Height": 90815
}


It took a while to find legal tithe.


exec istithelegal  cf5395b381fe371d0e418b51014299c0791df6911bd7bf1d5702afe540b1d704

{
  "Command": "istithelegal",
  "Tithe_Legal": true,
  "Tithe_Age": 6.50332175925926,
  "Tithe_Spent_Coin_Amount": 4927,
  "Tithe_Amount": 294,
  "Block_diff_min_coin_age": 0.76,
  "Block_diff_min_coin_amt": 319,
  "Block_diff_max_tithe_amt": 296,
  "Tithed_Height": 89920
}


Now I'm out of aged coins.
It looks like that it is possible to tithe from commandline client illegal tithes


I believe you have a point, good find on the old txid, thanks.


Let me do some testing and ensure we are using the correct difficulty in the best block as compared to the inductor.



Rob Andrews

Quote from: Rob Andrews on December 19, 2018, 12:28:56 PM

I believe you have a point, good find on the old txid, thanks.


Let me do some testing and ensure we are using the correct difficulty in the best block as compared to the inductor.

Ok, I found this was a bug in the wallet.  We quote the current diff params to the user, but during block checking we should have been checking the prior block - not the current block - OK this is fixed in the next version.



Rob Andrews

New version is building.... Should be out tonight.

Massive changes, please hold off on testing.


Rob Andrews

1.1.7.0 - Mandatory Upgrade for TestNet


- Add groundwork for future BiblePay chat room (testnet) and first native bitcoin chat protocol (and call a Priest)
- Add ability for web supporter sites to add proposals, and add in the ExpenseType field (allowing web sites to add proposals with expense types)
- Fix exec pogpool to respect height (exec pogpool height)
- Fix transactionlist UI display bug showing mining payments as POG payments (also fix PODC payments that should be mining payments)
- Update exec titheinfo to show proper ROI, daily miner rewards, and daily tithe cap
- Alter Tithe Cap in testnet and prod (prod is disabled) to be accurate (this is 50K per day, with 100K mining payments) - this means TestNet should disregard all old blocks before 90,000 and start new tests going forward
- Assess block difficulty params in IsTitheLegal using the previous block, but quote diff params for current best block (fixes the Illegal Tithes issues)



MIP

Quote from: Rob Andrews on December 19, 2018, 11:43:07 PM
1.1.7.0 - Mandatory Upgrade for TestNet



MacOS testnet version ready, Ubuntu PPAs building now.