Testnet June 2018 Mandatory Upgrade Testing Thread

I took a look at the pull request. I was actually looking for a 'superblock payment' filter last week when I needed an overview of BBP payments for CameroonONe. Awesome!

Unrelated: I've updated my Sanctuary to 1.1.3.4. Rob, are there specific things we need to test now?

I just released the latest version as a windows version also btw.


Let me see what test cases are left.

Could someone do me a favor who is running the daemon and see if this has stopped happening?

https://github.com/biblepay/biblepay/issues/5

I never had this happen to me...

biblepaytest.conf
testnet=1
server=1
masternodeprivkey=xxx
masternode=0

-conf as a parameter to cdhoose different .conf file didn't work for me, but putting testnet=1 in biblepay.conf worked.

biblepaytest.conf
testnet=1
server=1
masternodeprivkey=xxx
masternode=0

then i ran biblepay-qt -conf=biblepaytest.conf but when i go to tools debug console, says network is main.

my receive address starts with a b, so i don't think i'm in testnet

-conf didn't work for me, but putting testnet=1 in biblepay.conf worked.

sorry if you covered in this thread or another...

looks like i mined 1M in a few minutes enough for MN.

I never tried the '-conf' line, but you can also add the '-testnet' line, and your wallet will start in testnet.

Could someone do me a favor who is running the daemon and see if this has stopped happening?

https://github.com/biblepay/biblepay/issues/5

I tested from QT Wallet, Tools >> Debug Console >>> stop, no issues

Ran command line daemon, waited for blocks to load and verify, ./biblepay-cli stop, no issues

I'm not sure if its the same thing, but when heatmining on windows I see several c++ crash messages pop up briefly as i'm closing the wallet. 

Still trying to get to debug it, my assumptionis the mining threads are not stopping before the rest of the client is shutting down.

Once I can find the smoking gun i'll let you know.

I tested from QT Wallet, Tools >> Debug Console >>> stop, no issues

Ran command line daemon, waited for blocks to load and verify, ./biblepay-cli stop, no issues

Thanks, I strongly believe I caused the stop issue when I was working on the podc unlock feature.  It had something to do with asking the headless user for the password modally.  I remember I moved that feature over to the the biblepay-cli tool (so it would be on demand not modal).

Im pretty sure that fixed the problem on that day, so Ill close the stop issue for now.

biblepaytest.conf
testnet=1
server=1
masternodeprivkey=xxx
masternode=0

-conf as a parameter to cdhoose different .conf file didn't work for me, but putting testnet=1 in biblepay.conf worked.

Using the -conf parameter is a way to get around adding all the other flags on boot (IE -testnet=1) etc.  But more importantly it allows you to set a different rpcport than your running prod instance.

Anyway if you put your biblepaytest.conf in your ~/.biblepaycore directory it should work. 
Start with

./biblepay-qt -conf=biblepaytest.conf

Also, you can put testnet=1 in your biblepaytest.conf, and leave it out of biblepay.conf. 

===
MINOR  UI:

- Move Proposals menu to a tab like Sanctuaries
---- Set Proposal List to be its own internal window
- Add Scrolling and Dragging abilities to Proposal List
---- or Find way to Shorten the information

===
QUESTION #1:
Should the Proposals Window also show other Governance information?

===
NICE TO HAVE:

--- Add Next Superblock Block Number (getgovernanceinfo: "nextsuperblock")
--- Add Superblock Budget Amount (getgovernanceinfo: "nextbudget")

--- Add Estimated Superblock Date/Time
(("nextsuperblock" - currentblock) * 7 min avg block time)

--- Add Visual Indicator or Sort/Separate Proposals based on if they are currently passing or not.
Example: https://dashvotetracker.com/

--- Add Full Budget Bar Chart (Total Budget and Currently Passing Budget)

===
HARDER:

--- Add ability to View Previous/Past Superblocks proposals/charts/info
--- Add Multi Bar Chart Split by Budget sections/types (IT, PR, P2P)

===
QUESTION #2:
- Add ability to Create Proposal to Wallet,
I assume we still need to wait on this?

============
IDEAS (NEED FEEDBACK):

- Pop Up / Notification
--- when New Proposal submitted?
--- Reminder to Vote on Proposals X days before end of cycle?
--- when Superblock is mined?
--- when Masternode leaves ENABLED state?

===
REFERENCES:

https://www.biblepay-central.org/en/proposals/
https://pool.biblepay.org/ >>> Governance >>> Proposal List

So taking a look at this list, 
on the minor UI:

- Move Proposals menu to a tab like Sanctuaries
---- Set Proposal List to be its own internal window
- Add Scrolling and Dragging abilities to Proposal List
---- or Find way to Shorten the information

we have Anton (Bezaleel) who volunteered to do this, so we are good here. 

On the Full Budget Bar Chart:
I have Bhavani working on our new Great Tribulation feature (thats the one where we have a Map of all Christians with longitude and latitude of the street corner they are near for privacy), so I think I can get Bhavani to add this Full Budget Bar Chart feature also.

On the Adding Proposals through the wallet itself:
I like the idea, it will help our decentralization.  Since I need to add some code to the pool to give it ability to pick up proposals entered through the core, I can take care of this feature. 


On everything else:  All I can suggest is if TheSnat wants to do them.  Snat, if you want to do the popups, there is a place in the code where we show a bible verse upon receiving BBP inbound.  You could potentially use that code to make these other pop ups, if you want.

On the Full Budget Bar Chart:
I have Bhavani working on our new Great Tribulation feature (thats the one where we have a Map of all Christians with longitude and latitude of the street corner they are near for privacy), so I think I can get Bhavani to add this Full Budget Bar Chart feature also.

I'm curious the logic behind this feature...  If in fact its during the great Tribulation, the last thing i'd want is to give away my position..
What is the source for this data?  (sounds interesting overall)

On everything else:  All I can suggest is if TheSnat wants to do them.  Snat, if you want to do the popups, there is a place in the code where we show a bible verse upon receiving BBP inbound.  You could potentially use that code to make these other pop ups, if you want.

Sure sounds good.

I think there should be a control option for the popups as well..  (ie simple way to turn them off in the gui)
Perhaps a new tab on the options screen?

I'm curious the logic behind this feature...  If in fact its during the great Tribulation, the last thing i'd want is to give away my position..
What is the source for this data?  (sounds interesting overall)

Sure sounds good.

I think there should be a control option for the popups as well..  (ie simple way to turn them off in the gui)
Perhaps a new tab on the options screen?

Well its sort of a multi-use feature.  Im thinking of having people store their nickname, long, lat (of street corner) and Christian testimony in the chain, and optionally e-mail address and BBP receive address (using a Contact Card - Add feature).  This would allow us to send/receive to each other by nickname or email.  And read others Christian testimonies.

The idea behind the great trib feature is if the rapture occurs, the idea is a user could go to our map and find areas of light (IE other biblepay users) to camp with. 

If you want to add a checkable option, sure, you could add it somewhere in the settings page, what about in Settings | Options | Wallet as another checkbox?  If you want a new tab go for it.

Regarding the last outstanding test issues before go-live, I think we are now 95% there.

Recently 616 had a feature request in github suggesting we allow PODCH-heat mining to occur as long as the user has magnitude within the last 7 days, to keep them operating continiously.  This has been merged in the newest version, 1.1.3.5.  So that needs tested from the perspective that 1.1.3.5 can still heat mine without an error.

(I tested from the perspective to see if all CPIDs who have mag in the last 7 days are in my exec datalist search feature, and they are, so its relatively safe).

I believe we tested TheSnat's filters.  They look good.

On this next version, I enabled Proposals List UI in Prod so we can not only see the list of our 10 in prod, but lets test the filter to see if they dissapear after this superblock hits.

Regarding mature consensus, it passed test.  I also see we have been making quite a lot of PODC superblocks.

Ill take a look to see if we missed anything.

Windows is compiling.  Linux has been released to github.

Also, you can put testnet=1 in your biblepaytest.conf, and leave it out of biblepay.conf. 

BTC Talk said you could run biblepay-qt as a portable app.
So, I have a folder called biblepay and another one for biblepaytest

I thought adding -testnet automatically uses different rpcport

Can someone send me 501k tBBP to yW3evG8mKvbb8oL6Tq9bys7KrxxadMuWMj ?

Thanks.

Can someone send me 501k tBBP to yW3evG8mKvbb8oL6Tq9bys7KrxxadMuWMj ?

Sent

One of my testnet-wallets crashed with this message:

terminate called after throwing an instance of 'std::runtime_error'
  what():  CWallet::GenerateNewKey(): AddKey failed
Aborted (core dumped)

I don't think there is anything unusual in the debug.log.