Bible Pay

Read 1874 times

  • togoshigekata
  • Sr. Member

    • 275


    • 17
    • September 01, 2017, 10:21:10 am
    • Texas, USA
    more
Re: Testnet June 2018 Mandatory Upgrade Testing Thread
« Reply #30 on: June 15, 2018, 03:06:18 pm »
Updated to v1.1.2.8, got a bad_alloc crash,
wiped all the .dat files and folders, reindexed, got a bad_alloc crash

Ive been using console version of BiblePay, so I just tried QT version, and I got:

Code: [Select]
Segmentation fault (core dumped)
re-ran QT again, and got:

Code: [Select]
************************
EXCEPTION: St11logic_error
basic_string::_M_construct null not valid
biblepay in ProcessMessages()

terminate called after throwing an instance of 'std::bad_alloc'
  what():  std::bad_alloc
Aborted (core dumped)


  • Rob A.
  • Administrator

    • 1101


    • 18
    • June 05, 2017, 08:09:04 pm
    • Patmos, Island Of
    more
Re: Testnet June 2018 Mandatory Upgrade Testing Thread
« Reply #31 on: June 15, 2018, 03:08:08 pm »
Updated to v1.1.2.8, got a bad_alloc crash,
wiped all the .dat files and folders, reindexed, got a bad_alloc crash

Ive been using console version of BiblePay, so I just tried QT version, and I got:

Code: [Select]
Segmentation fault (core dumped)
re-ran QT again, and got:

Code: [Select]
************************
EXCEPTION: St11logic_error
basic_string::_M_construct null not valid
biblepay in ProcessMessages()

terminate called after throwing an instance of 'std::bad_alloc'
  what():  std::bad_alloc
Aborted (core dumped)

Could you please try it in valgrind mode?

Ill take a look...


EDIT:  Im running it in valgrind now...


« Last Edit: June 15, 2018, 03:43:00 pm by Rob A. »


  • Rob A.
  • Administrator

    • 1101


    • 18
    • June 05, 2017, 08:09:04 pm
    • Patmos, Island Of
    more
Re: Testnet June 2018 Mandatory Upgrade Testing Thread
« Reply #32 on: June 15, 2018, 06:29:17 pm »
Ok all, we didn't really fix the general protection fault in 1.1.2.8 or 1.1.2.9, but the good news is I found the root cause to be old testnet CPIDs whom do not have the unbanked indicator, causes the GPF error in the new version, in testnet only, hence the reason this didnt affect prod.

I'm compiling 1.1.3.0 now - will notify when ready....


  • Rob A.
  • Administrator

    • 1101


    • 18
    • June 05, 2017, 08:09:04 pm
    • Patmos, Island Of
    more
Re: Testnet June 2018 Mandatory Upgrade Testing Thread
« Reply #33 on: June 15, 2018, 09:54:18 pm »
Ok all, we didn't really fix the general protection fault in 1.1.2.8 or 1.1.2.9, but the good news is I found the root cause to be old testnet CPIDs whom do not have the unbanked indicator, causes the GPF error in the new version, in testnet only, hence the reason this didnt affect prod.

I'm compiling 1.1.3.0 now - will notify when ready....

1.1.3.0 is ready for testing!



  • Rob A.
  • Administrator

    • 1101


    • 18
    • June 05, 2017, 08:09:04 pm
    • Patmos, Island Of
    more
Re: Testnet June 2018 Mandatory Upgrade Testing Thread
« Reply #34 on: June 15, 2018, 09:55:45 pm »
Someone is voting against the 'groundbreaking proposal'.  Why dont we vote For it so we can test the pie chart?



  • togoshigekata
  • Sr. Member

    • 275


    • 17
    • September 01, 2017, 10:21:10 am
    • Texas, USA
    more
Re: Testnet June 2018 Mandatory Upgrade Testing Thread
« Reply #35 on: June 15, 2018, 11:32:28 pm »
Updated to v1.1.3.0, running for 2 hours console, no crashes,
(usually was crashing within first minute or two previously), now running in QT mode

===

Proposals >>> Proposal List

I right clicked >>> "Vote For" >>> Yes >>> Ok
on both proposals, but no values changed,
closed and reopened proposal list, values were the same,
basically my votes arent showing up, which makes me think maybe my Sanctuary isnt Enabled

but Sanctuaries tab shows my masternode as ENABLED, "masternode status" shows it as running successfully, watchman is set to testnet, crontab is setup, "cd ~/.biblepaycore/watchman && ./venv/bin/python bin/watchman.py" runs successfully with no output

Does my Sanctuary show as Enabled?
Payee: yaoWiP*****yqZUUo

===

EDIT: 3 hours QT, no crashes

Thank you Rob!  8)
« Last Edit: June 16, 2018, 02:16:41 am by togoshigekata »


  • jaapgvk
  • Sr. Member

    • 494


    • 20
    • September 01, 2017, 08:02:57 pm
    • Netherlands
    more
Re: Testnet June 2018 Mandatory Upgrade Testing Thread
« Reply #36 on: June 16, 2018, 02:30:26 am »
Someone is voting against the 'groundbreaking proposal'.  Why dont we vote For it so we can test the pie chart?

I voted 'for' in QT but my vote got added to the 'no ct'  :-\


  • Rob A.
  • Administrator

    • 1101


    • 18
    • June 05, 2017, 08:09:04 pm
    • Patmos, Island Of
    more
Re: Testnet June 2018 Mandatory Upgrade Testing Thread
« Reply #37 on: June 16, 2018, 09:29:12 am »
I voted 'for' in QT but my vote got added to the 'no ct'  :-\


Oh my :), LOL, I think we fixed the wrong thing in voting.  Ok, I do confirm that we are sending the wrong signal.

Alright fixed.  So I just pushed out 1.1.3.1 to fix the voting, windows is compiling now.

10-4 Togo on the crash, thats at least 70% of the weight of the camel off our back now in testnet!



  • Rob A.
  • Administrator

    • 1101


    • 18
    • June 05, 2017, 08:09:04 pm
    • Patmos, Island Of
    more
Re: Testnet June 2018 Mandatory Upgrade Testing Thread
« Reply #38 on: June 16, 2018, 11:32:51 am »
Updated to v1.1.3.0, running for 2 hours console, no crashes,
(usually was crashing within first minute or two previously), now running in QT mode

===

Proposals >>> Proposal List

I right clicked >>> "Vote For" >>> Yes >>> Ok
on both proposals, but no values changed,
closed and reopened proposal list, values were the same,
basically my votes arent showing up, which makes me think maybe my Sanctuary isnt Enabled

but Sanctuaries tab shows my masternode as ENABLED, "masternode status" shows it as running successfully, watchman is set to testnet, crontab is setup, "cd ~/.biblepaycore/watchman && ./venv/bin/python bin/watchman.py" runs successfully with no output

Does my Sanctuary show as Enabled?
Payee: yaoWiP*****yqZUUo

===

EDIT: 3 hours QT, no crashes

Thank you Rob!  8)

Hi Togo, once we get 1.1.3.1 up, try this:
gobject list all proposals
gobject vote-many gobjectid funding yes

See if there is a different outcome when voting from RPC, and that will let us isolate the proposal code from the standard voting code.



  • Rob A.
  • Administrator

    • 1101


    • 18
    • June 05, 2017, 08:09:04 pm
    • Patmos, Island Of
    more
Re: Testnet June 2018 Mandatory Upgrade Testing Thread
« Reply #39 on: June 16, 2018, 02:48:16 pm »
1.1.3.1 has been released. 

Now we should have no crashes and be able to vote properly and see the pie chart.


  • togoshigekata
  • Sr. Member

    • 275


    • 17
    • September 01, 2017, 10:21:10 am
    • Texas, USA
    more
Re: Testnet June 2018 Mandatory Upgrade Testing Thread
« Reply #40 on: June 16, 2018, 03:06:49 pm »
Updated to v1.1.3.1

Voted with Proposal List, vote didnt change, but if I opened a new Proposal List, the change is there!,
Voting For, Against and Abstain all worked, but only reflected in new Proposal List windows.
Viewing the pie charts and proposal links worked.

Note: I had to install a web browser to use View Proposal, I installed Firefox
sudo apt-get install firefox


  • jaapgvk
  • Sr. Member

    • 494


    • 20
    • September 01, 2017, 08:02:57 pm
    • Netherlands
    more
Re: Testnet June 2018 Mandatory Upgrade Testing Thread
« Reply #41 on: June 16, 2018, 03:31:52 pm »
Updated to v1.1.3.1

Voted with Proposal List, vote didnt change, but if I opened a new Proposal List, the change is there!,
Voting For, Against and Abstain all worked, but only reflected in new Proposal List windows.
Viewing the pie charts and proposal links worked.

Note: I had to install a web browser to use View Proposal, I installed Firefox
sudo apt-get install firefox

Same here. Everything seems to work now, you just have to close the 'proposal list' window and open it again to see the changes. Perhaps some kind of 'refresh' button would be helpful, or an auto-refresh after voting?


  • Rob A.
  • Administrator

    • 1101


    • 18
    • June 05, 2017, 08:09:04 pm
    • Patmos, Island Of
    more
Re: Testnet June 2018 Mandatory Upgrade Testing Thread
« Reply #42 on: June 16, 2018, 04:07:19 pm »
Updated to v1.1.3.1

Voted with Proposal List, vote didnt change, but if I opened a new Proposal List, the change is there!,
Voting For, Against and Abstain all worked, but only reflected in new Proposal List windows.
Viewing the pie charts and proposal links worked.

Note: I had to install a web browser to use View Proposal, I installed Firefox
sudo apt-get install firefox

So I just reproduced the error you had yesterday with failed to vote via proposal list (gobject mngovernance error).

In my case, I had created a hot masternode, put masternode=1 and masternodeprivkey=xxx in the biblepaytest.conf, then I couldnt vote because there was no masternode.conf for it to iterate through during voting (vote-many).
So I entered the outpoint and the genkey in masternode.conf, and I was able to vote unsuccessfully, and got the error you got.
Then I copied masternode.conf into \testnet3, and then I *was* able to vote successfully.

So I think this is OK for testnet, as this particular voting system iterates through registered masternodes in the masternode.conf.
It might be nice for us to add some options to allow it to vote Once (using the first masternode), or Vote Many...  But lets add that to the wish list for now as there are important things to do first (like form our DAO trust and make the pool list total charitable expenses) etc.

Glad you were able to vote!



  • Rob A.
  • Administrator

    • 1101


    • 18
    • June 05, 2017, 08:09:04 pm
    • Patmos, Island Of
    more
Re: Testnet June 2018 Mandatory Upgrade Testing Thread
« Reply #43 on: June 16, 2018, 04:10:25 pm »
Same here. Everything seems to work now, you just have to close the 'proposal list' window and open it again to see the changes. Perhaps some kind of 'refresh' button would be helpful, or an auto-refresh after voting?

Yes, I confirm it doesnt really refresh after it votes.  Ill take a look at that. 

Please, if anyone else has any very high priority wish list items for this release by all means please list them...



PS  I was able to vote successfully through the UI on my hot masternode.    Overall this is a real breakthrough, as I believe we are the first masternode coin with a Proposals UI in the wallet.  This is something Dash has to go to the dash-central to do, yet we can vote within the wallet!





  • togoshigekata
  • Sr. Member

    • 275


    • 17
    • September 01, 2017, 10:21:10 am
    • Texas, USA
    more
Re: Testnet June 2018 Mandatory Upgrade Testing Thread
« Reply #44 on: June 16, 2018, 07:14:31 pm »
PS  I was able to vote successfully through the UI on my hot masternode.    Overall this is a real breakthrough, as I believe we are the first masternode coin with a Proposals UI in the wallet.  This is something Dash has to go to the dash-central to do, yet we can vote within the wallet!

This is really neat, good work Bhavani and Rob!

I believe PIVX has it on their roadmap for this year:
https://pivx.org/pivx-roadmap-2018/
"In Wallet Proposal Tab" and "In Wallet Voting Tab"

but I havent seen it released yet:
https://github.com/PIVX-Project/PIVX/releases

(Im curious to try out different coin wallets now)

I see this helping make voting easier! as well as spread awareness!

===

Feedback & Ideas:

- Move Proposals menu to a tab like Sanctuaries? (its more hidden as a menu item)

- Set Proposal List to be its own internal window vs a new spawned window?

- Add Scrolling and Dragging abilities to Proposal List or try way to Compact Info?
(my proposal list window goes off the screen on a small screen computer, a lot of information on the width)

=

Going Further:

- Add Visual Indicator or Sort/Separate Proposals based on if they are currently passing or not
Example: https://dashvotetracker.com/

- Integrate any BiblePay Pool and/or BiblePay Central Proposal/Governance Info/Charts
https://www.biblepay-central.org/en/proposals/
https://pool.biblepay.org/ >>> Governance >>> Proposal List

--- Add Superblock Budget Amount to UI
--- Add Next Superblock Block Number to UI
--- Add Estimated Superblock Date/Time to UI

--- Add Full Budget Bar Chart (Total Budget and Currently Passing Budget)

--- Add Multi Bar Chart Split by Budget sections/types
(I believe main BiblePay Pool only knows which budget section a proposal is set to?
In the future do we want to add Budget sections into the core code?)

--- Add ability to View Previous/Past Superblocks proposals/charts/info

=

- Add ability to Create Proposal with UI

=

- Pop Up / Notification when New Proposal submitted?
- Pop Up / Notification Reminder to Vote on Proposals X days before end of cycle?
- Pop Up / Notification when Superblock is mined?
- Pop Up / Notification when Masternode leaves ENABLED state?
« Last Edit: June 17, 2018, 06:06:37 am by togoshigekata »