Testnet June 2018 Mandatory Upgrade Testing Thread

[Rob Andrews]

===
MINOR  UI:

- Move Proposals menu to a tab like Sanctuaries
---- Set Proposal List to be its own internal window
- Add Scrolling and Dragging abilities to Proposal List
---- or Find way to Shorten the information

===
QUESTION #1:
Should the Proposals Window also show other Governance information?

===
NICE TO HAVE:

--- Add Next Superblock Block Number (getgovernanceinfo: "nextsuperblock")
--- Add Superblock Budget Amount (getgovernanceinfo: "nextbudget")

--- Add Estimated Superblock Date/Time
(("nextsuperblock" - currentblock) * 7 min avg block time)

--- Add Visual Indicator or Sort/Separate Proposals based on if they are currently passing or not.
Example: https://dashvotetracker.com/

--- Add Full Budget Bar Chart (Total Budget and Currently Passing Budget)

===
HARDER:

--- Add ability to View Previous/Past Superblocks proposals/charts/info
--- Add Multi Bar Chart Split by Budget sections/types (IT, PR, P2P)

===
QUESTION #2:
- Add ability to Create Proposal to Wallet,
I assume we still need to wait on this?

============
IDEAS (NEED FEEDBACK):

- Pop Up / Notification
--- when New Proposal submitted?
--- Reminder to Vote on Proposals X days before end of cycle?
--- when Superblock is mined?
--- when Masternode leaves ENABLED state?

===
REFERENCES:

https://www.biblepay-central.org/en/proposals/
https://pool.biblepay.org/ >>> Governance >>> Proposal List

So taking a look at this list, 
on the minor UI:

- Move Proposals menu to a tab like Sanctuaries
---- Set Proposal List to be its own internal window
- Add Scrolling and Dragging abilities to Proposal List
---- or Find way to Shorten the information

we have Anton (Bezaleel) who volunteered to do this, so we are good here. 

On the Full Budget Bar Chart:
I have Bhavani working on our new Great Tribulation feature (thats the one where we have a Map of all Christians with longitude and latitude of the street corner they are near for privacy), so I think I can get Bhavani to add this Full Budget Bar Chart feature also.

On the Adding Proposals through the wallet itself:
I like the idea, it will help our decentralization.  Since I need to add some code to the pool to give it ability to pick up proposals entered through the core, I can take care of this feature. 


On everything else:  All I can suggest is if TheSnat wants to do them.  Snat, if you want to do the popups, there is a place in the code where we show a bible verse upon receiving BBP inbound.  You could potentially use that code to make these other pop ups, if you want.

[Rob Andrews]

I'm curious the logic behind this feature...  If in fact its during the great Tribulation, the last thing i'd want is to give away my position..
What is the source for this data?  (sounds interesting overall)

Sure sounds good.

I think there should be a control option for the popups as well..  (ie simple way to turn them off in the gui)
Perhaps a new tab on the options screen?

Well its sort of a multi-use feature.  Im thinking of having people store their nickname, long, lat (of street corner) and Christian testimony in the chain, and optionally e-mail address and BBP receive address (using a Contact Card - Add feature).  This would allow us to send/receive to each other by nickname or email.  And read others Christian testimonies.

The idea behind the great trib feature is if the rapture occurs, the idea is a user could go to our map and find areas of light (IE other biblepay users) to camp with. 

If you want to add a checkable option, sure, you could add it somewhere in the settings page, what about in Settings | Options | Wallet as another checkbox?  If you want a new tab go for it.

[Rob Andrews]

Regarding the last outstanding test issues before go-live, I think we are now 95% there.

Recently 616 had a feature request in github suggesting we allow PODCH-heat mining to occur as long as the user has magnitude within the last 7 days, to keep them operating continiously.  This has been merged in the newest version, 1.1.3.5.  So that needs tested from the perspective that 1.1.3.5 can still heat mine without an error.

(I tested from the perspective to see if all CPIDs who have mag in the last 7 days are in my exec datalist search feature, and they are, so its relatively safe).

I believe we tested TheSnat's filters.  They look good.

On this next version, I enabled Proposals List UI in Prod so we can not only see the list of our 10 in prod, but lets test the filter to see if they dissapear after this superblock hits.

Regarding mature consensus, it passed test.  I also see we have been making quite a lot of PODC superblocks.

Ill take a look to see if we missed anything.

Windows is compiling.  Linux has been released to github.

[sunk818]

Also, you can put testnet=1 in your biblepaytest.conf, and leave it out of biblepay.conf. 

BTC Talk said you could run biblepay-qt as a portable app.
So, I have a folder called biblepay and another one for biblepaytest

I thought adding -testnet automatically uses different rpcport

Can someone send me 501k tBBP to yW3evG8mKvbb8oL6Tq9bys7KrxxadMuWMj ?

Thanks.

[jaapgvk]

Can someone send me 501k tBBP to yW3evG8mKvbb8oL6Tq9bys7KrxxadMuWMj ?

Sent

[jaapgvk]

One of my testnet-wallets crashed with this message:

terminate called after throwing an instance of 'std::runtime_error'
  what():  CWallet::GenerateNewKey(): AddKey failed
Aborted (core dumped)

I don't think there is anything unusual in the debug.log.

[Rob Andrews]

All,

1.1.3.6 is ready for testing for all platforms.

In this version we now have the ability to add proposals.
NOTE: You must have your wallet unlocked before submitting the proposal.
After submitting the proposal you must check back on the Proposal Add page after 6 confirms to see if it went in the chain.

Lets test that.

Lets also test the ability to heat mine in 1136.

We also moved the Proposal List to an integrated tab for more professionalism.
Additionally, we made the List update whenever you switch tabs and give it focus.

Hopefully this version will become the release candidate.

[Rob Andrews]

hmm, testing heat mining, did you change something there?

I noticed .3.6 seems to take longer to load the block index. (could be cause of the forks going on currently in prod).

I also had some crashes on the windows client on 3.6 while mining.  (go back to machine and the wallet is just gone heh)

edit: crashes seem to be because of the mining issues today, may not be related to the update. so far had 3.1,3.3, and 3.6 crash

Hmm lets test everything in testnet today; not a good day to intermingle testing with prod.

No, doesn't take longer to load the block index.  Lets try to only post a statement if you KNOW its true.  Meaning that you ran a baseline and have something to compare to.  And you know your hard drive cache was empty both times.

Hmm, shouldnt have any crashes if you are mining on one thread.  What are you mining with, 60 threads?  And what OS?  It would be helpful to post the tail of the log (in a code snippet of course) if you encounter a crash.  Try to reproduce it on linux with valgrind then you can give me the line #.

[jaapgvk]

I'm creating some proposals from the wallet now. Am I correct in asserting that the fee for the proposals are paid right from the wallet (the fee seems to be 5 BBP now, but that's probably because we are in testnet)?

Frankly, I think that is amazing!

[Rob Andrews]

I'm creating some proposals from the wallet now. Am I correct in asserting that the fee for the proposals are paid right from the wallet (the fee seems to be 5 BBP now, but that's probably because we are in testnet)?

Frankly, I think that is amazing!

Yes, the reason its currently 5 bbp, is we went live with that value last year.  However I feel that will end up eventually being abused (as it was in the pool at first), and also, we have been charging 2500 historically in the pool, so I made a transition point as of August 1 to switch over to 2500 BBP for the collateral fee.  So in prod, it will temporarily be 5 also until that date.

Im going to look at any outstanding test cases; we really need to ramp up testing this weekend in order to try to get a version out soon; we cant notify the exchanges of a coming mandatory unless we are sure of a release date.

[Rob Andrews]

Loading of the index, was noticeably longer on several machines in prod(I'm talking 30sec to 5+min difference) I suspect this is due to the current issue and all the orphan blocks.   


as for mining,  I have several machines mining 4 cores...  windows of course so no valgrind.  I won't be around tomorrow, but i'll see if i can get logs.

Testing this morning on one home linux and one VM block index seems to load fast, I think it might have been an anomaly.

[jaapgvk]

Yes, the reason its currently 5 bbp, is we went live with that value last year.  However I feel that will end up eventually being abused (as it was in the pool at first), and also, we have been charging 2500 historically in the pool, so I made a transition point as of August 1 to switch over to 2500 BBP for the collateral fee.  So in prod, it will temporarily be 5 also until that date.

Im going to look at any outstanding test cases; we really need to ramp up testing this weekend in order to try to get a version out soon; we cant notify the exchanges of a coming mandatory unless we are sure of a release date.

I feel that the 5 BBP will definitely make it easy to abuse the function. 2500BBP I think works well, as you can ask the 2500BBP back in your proposal. If you have a good proposal you have nothing to fear.

This Sunday will be my 'BiblePay day', so I will test a lot and try a lot. A tiny thing that I have for now is that you can still also access the proposal-tab from the top menu. That's probably redundant now.

[Rob Andrews]

I feel that the 5 BBP will definitely make it easy to abuse the function. 2500BBP I think works well, as you can ask the 2500BBP back in your proposal. If you have a good proposal you have nothing to fear.

This Sunday will be my 'BiblePay day', so I will test a lot and try a lot. A tiny thing that I have for now is that you can still also access the proposal-tab from the top menu. That's probably redundant now.

Yes, Im in total agreement, and I have it set to where we can move the Proposal-Add to the top menu, and just see the Proposals from the left menu; I figured I would leave it like this until Anton gets it as he is working on some things that affect the menu right now.

[togoshigekata]

Updated to v1.1.3.6

New tabbed Proposals List
Proposal Add
and "exec totalrac"
are AWESOME!

[Rob Andrews]

Hey, sorry TheSnat, I finally accidentally encountered the long load time for the block index on one of my windows machines (IE > 5 mins, compared to normally 20 seconds).

I think this has something to do with the loading of the prayers in the background...  It makes me nervous; will need to look into it today.

At the worst, I feel its safer if we let the prayers load serially like we used to-and delay the start by 10 seconds... Ill take a look.  I hate to delay the release much longer.