BIBLEPAY - DOGE DECENTRALIZED EXCHANGE

ive been trading with myself using 2 machines and im not able to replicate what happened previously

Yeah its weird because I havent seen that happen to any of my 3 installs (it may be a race condition).
Can you tell me exactly what is the label on each of them?  "TRADING-ASSET-DOGE"?  Yeah, they were both mined as DGZZ DOGE asset addresses so they are valid.  Technically the wallet should work fine with two of those.  I will add code very soon to show the address in 'exec getassetbalance' that goes along with the amount.

Hi Rob,

Both addresses have the same label:  "TRADING-ASSET-DOGE"

When I check my asset balance at the console, it reports only one of them though: B98GozkCagidcdFMY2zyKf7k3ioud2DgZz (it seems to hold the wrapped DOGE from my only transaction on the exchange)

ive been trading with myself using 2 machines and im not able to replicate what happened previously

Great on two machines, we will test this extensively before moving it to prod.
Ill also put a mutex on it when we are in there next time for anything.
In the mean time feel free to try to abuse it.

It also could have been during the transition from the fork to instantsend.  If you want, you can reindex your wallet and check and see if any orphaned tx's are released to your main balance.

(Unfortuantely dash took out the feature called -zapwallettxes=1 otherwise I would suggest that).

I think the main priority is to try to see if there is ever an error with these.

One other feature we could probably add, is for me to log the trading balance and the doge balance every time something is done in the tradinglog.  We have a tradinglog.dat file being appended now.

Hi Rob,

Both addresses have the same label:  "TRADING-ASSET-DOGE"

When I check my asset balance at the console, it reports only one of them though: B98GozkCagidcdFMY2zyKf7k3ioud2DgZz (it seems to hold the wrapped DOGE from my only transaction on the exchange)

Ok, so to get rid of the second one, just pick the one where the address is not equal to the official one in the RPC output, just edit it and make it something completely different like 'old-asset-doge' and then it wont be used by the wallet.

We will keep an eye on this behavior and see if it happens again.  Ill also think of ways that could cause this race condition.

So I assume, with lack of any more complaints that everything is working perfectly as far as trades with perfect matches.

Im going to move on to partial fills next.

Please keep an eye out for the next mandatory upgrade- most likely by the weekend.

If anyone can do any more testing, please do it so we can build on something that already works properly.

Hi Rob,

I still keep getting public trading key is 1 when i try to sell some bbp,  and i have funded it a couple of times.

any ideas? wallet is unlocked, and i have waited a few blocks.

Hi Rob,

I still keep getting public trading key is 1 when i try to sell some bbp,  and i have funded it a couple of times.

any ideas? wallet is unlocked, and i have waited a few blocks.

Hi Bro Budinga,
Can you give me an example or a paste of what output you mean?
Im not sure what you mean.

Heres two things you can try:
1) exec getassetbalance trading
Verify balance is good (^ that command only works on the latest version of the wallet btw).

2) From coin control, find your 'TRADING-PUBLIC-KEY' and verify it has a positive balance.
You may have spent some from it, if so you can just re-send funds to it.
Then you can LOCK the funds with Coin Control to keep that from happening again.
The exchange can spend from it when an order is filled.

Hi Bro Budinga,
Can you give me an example or a paste of what output you mean?
Im not sure what you mean.

Heres two things you can try:
1) exec getassetbalance trading
Verify balance is good (^ that command only works on the latest version of the wallet btw).

2) From coin control, find your 'TRADING-PUBLIC-KEY' and verify it has a positive balance.
You may have spent some from it, if so you can just re-send funds to it.
Then you can LOCK the funds with Coin Control to keep that from happening again.
The exchange can spend from it when an order is filled.

Hi Rob,

exec getassetbalance trading shows i have loads in it, but when i go to coin control the trading public key shows 1bbp. I just sent another 100k coins to see if it goes up.
Ill give it an hour or so, and see.

Hi Rob,

exec getassetbalance trading shows i have loads in it, but when i go to coin control the trading public key shows 1bbp. I just sent another 100k coins to see if it goes up.
Ill give it an hour or so, and see.

Ok now suddenly it seems to be working, maybe i was doing something wrong thanks rob.

Ok now suddenly it seems to be working, maybe i was doing something wrong thanks rob.

Ok, glad you got it working.
Just an FYI, both the colored DOGE and the Trading balance (but NOT the native DOGE), those two addresses are internal and should never be out of sync with coin control (as they are regular chain addresses).  If you see an amount in coin control, it must match what is on the RPC.
Unless wallet is syncing or out of sync.  Also, these two addresses use instantsend, so as long as you see a lightning bolt after releasing money to yourself, it is instantly available in the rpc and in the trading room.

The getassetbalance DOGE however, is your private key, but we make a DOGE rpc call to count your UTXOs in real time so that balance can be off for a few minutes if a DOGE block is being mined (for example if you recently spent a DOGE txid, you would see the last balance until the block is mined).  But nevertheless there cannot be a double spend because at the time of spending we spend the confirmed UTXO.

Ok, glad you got it working.
Just an FYI, both the colored DOGE and the Trading balance (but NOT the native DOGE), those two addresses are internal and should never be out of sync with coin control (as they are regular chain addresses).  If you see an amount in coin control, it must match what is on the RPC.
Unless wallet is syncing or out of sync.  Also, these two addresses use instantsend, so as long as you see a lightning bolt after releasing money to yourself, it is instantly available in the rpc and in the trading room.

The getassetbalance DOGE however, is your private key, but we make a DOGE rpc call to count your UTXOs in real time so that balance can be off for a few minutes if a DOGE block is being mined (for example if you recently spent a DOGE txid, you would see the last balance until the block is mined).  But nevertheless there cannot be a double spend because at the time of spending we spend the confirmed UTXO.

all seems good now. thanks.

I'm still testing for thourough coverage; I havent encountered any more new errors since our first test that AIDS reported.

Btw, fractional fills are almost done - and portfolio builder is almost ready to test.

I bought someones 60K sale and it worked as expected (BBP +60K, Doge down 2.5 or so).

Biblepay v0.24.2
Mandatory Upgrade

Make Exchange UI remember your row select positions, and refresh gracefully
Add pricing feeds (dogeusd,bbpusd,dogebbp) into the trading room UI, and add the midpoint to the center of the orderbook grids.
Add XLM/XRP multiwallet support
Add PortfolioBuilder phase 1 (XRP/DOGE/XLM) multiwallet
Added fractional fills to exchange, as long as the fractional remainder will be > 25K bbp

https://github.com/biblepay/biblepay/releases/tag/v024.2-Mandatory

To test Portfolio Builder:

Note that we have a new version of BBPExtensions, so after this newest upgrade, click on Extensions.
From that list of Apps, click Portfolio Builder.

The new wallet creates a few new keys:
ASSET-XLM
ASSET-XRP
ASSET-BBP

These are intended to be Portfolio Builder private keys (they never leave the machine and are private to your BBP core wallet).
The idea is when you send assets into these keys, they will be countable by Portfolio Builder (which gives you the ability to earn APR% annual rewards from the PB feature).  The rewards come in the form of Staked Block BBP rewards, which are not enabled yet).

So the way multi wallet works is when you launch PB, the BBP core wallet encrypts these 3 keys and sends them to the multiwallet.  Note the multiwallet runs on your machine in C#, so the keys are never exposed to the outside world.

However, with these 3 keys you can now send and receive XRP/XLM/DOGE from the multiwallet.

The code in the multiwallet is smart enough to create a Stellar or Ripple account if one does not exist.  So this only comes into play if you are sending Stellar from a BBP Stellar wallet to another BBP stellar wallet (we detect that and call the stellar c# code to create the new account).  If you fund Stellar from another stellar account they automatically create the account for you.

For Ripple, the XRP network will create an account for you if you fund the wallet with more than 20 XRP into your BBP Ripple wallet.  That is their network minimum (not ours).  Be careful if you plan on using Ripple, to send it more than 20 XRP to the address so that you don't lose the usability of the address.

In Phase 2, I will add the ability to see the APR% and you assessed staking level, and also to receive the extra rewards.

The Exchange has a couple new features:  You can see smooth refreshing, it remembers your last persisted row position that you clicked, it has some price feeds, and notice the midpoint (the current BBP-DOGE price) is on the middle of the screen.

To use the new fractional fills feature you must have a big enough order in that will result in more than 25,000 extra BBP after the fractional fill is filled.