Bible Pay

Read 155189 times

  • Rob Andrews
  • Administrator

    • 4090


    • 97
    • June 05, 2017, 08:09:04 PM
    • Patmos, Island Of
    more
Re: Testnet - Test Proof of Giving
« Reply #75 on: December 12, 2018, 10:11:07 AM »
i also seem to be able to select a 300 input and tithe 290. when done automatically, qt wallet wants to select a bigger input amount. is an input of 300, a legal tithe when the automated way wants mincoinvalue of 500?

So if you use coincontrol, Yes, that manual tithe would be legal.

The automated way chooses the first coin in the sorted vector that it finds that is legal that meets all the parameters, so it could be that is was in that order because of its age.  Its trying to spend the youngest aged coin that has a higher value than the diff level.

(Im testing the new version now, should be out today).



  • mint
  • Newbie

    • 18


    • 0
    • December 10, 2018, 10:19:06 AM
    more
Re: Testnet - Test Proof of Giving
« Reply #76 on: December 12, 2018, 11:48:06 AM »
Should I report issues or wait for new version?


  • sunk818
  • Global Moderator

    • 521


    • 36
    • April 24, 2018, 02:02:20 PM
    more
Re: Testnet - Test Proof of Giving
« Reply #77 on: December 12, 2018, 02:21:50 PM »
Makes sense Rob. Fro. The consumer side I'd prefer to Max tithe with very little change left over.  With the exec bankroll feature and some small change amounts, it may be a moot point.

Also, I'm confused by pog reward amounts.

One new wallet never tithed (too new) but I've been receiving pog rewards.

And then other times pog reward goes to non-tithe address. Is pog reward actually mined reward?
BH6oxjLkyz3z8FYpvU3ZR7PTZ31Xt9DkXZ


  • sunk818
  • Global Moderator

    • 521


    • 36
    • April 24, 2018, 02:02:20 PM
    more
Re: Testnet - Test Proof of Giving
« Reply #78 on: December 12, 2018, 02:24:02 PM »
Also, is pog reward a block that can process other transactions like Joe sending bbp to an exchange?
BH6oxjLkyz3z8FYpvU3ZR7PTZ31Xt9DkXZ


  • Rob Andrews
  • Administrator

    • 4090


    • 97
    • June 05, 2017, 08:09:04 PM
    • Patmos, Island Of
    more
Re: Testnet - Test Proof of Giving
« Reply #79 on: December 12, 2018, 04:00:37 PM »
Should I report issues or wait for new version?

Please wait, I believe we have to re-test everything in this new version as we now use a new more reliable method to induct legal tithes into the pool from the block.  Also, all prior versions had a bug in the actual CoinValue of the difficulty (it was off by COIN - a constant in the code), so yeah we need to re-test everything.

So Im thinking on our newer testing, we should do a limited number of tithes, like say 10 for example, and write them down in notepad with the block number (IE total amount and block number).  Then sit back and see exactly how many were inducted and exactly what rewards occur in 205 blocks.  This will give us a very accurate picture if 100% of the tithes are going in the pool, and the ratio of rewards per tithe BBP.

On a side note I added a new feature called 'exec istithelegal txid' - you can use this to test a tithe.



  • Rob Andrews
  • Administrator

    • 4090


    • 97
    • June 05, 2017, 08:09:04 PM
    • Patmos, Island Of
    more
Re: Testnet - Test Proof of Giving
« Reply #80 on: December 12, 2018, 04:02:43 PM »
Also, is pog reward a block that can process other transactions like Joe sending bbp to an exchange?

The POG reward is a coinbase, so it takes 120 confirms to become spendable (just like mining revenue).

On a side note, all the pool rewards for one block are contained in one transaction.



  • Rob Andrews
  • Administrator

    • 4090


    • 97
    • June 05, 2017, 08:09:04 PM
    • Patmos, Island Of
    more
Re: Testnet - Test Proof of Giving
« Reply #81 on: December 12, 2018, 04:05:53 PM »
Makes sense Rob. Fro. The consumer side I'd prefer to Max tithe with very little change left over.  With the exec bankroll feature and some small change amounts, it may be a moot point.

Also, I'm confused by pog reward amounts.

One new wallet never tithed (too new) but I've been receiving pog rewards.

And then other times pog reward goes to non-tithe address. Is pog reward actually mined reward?

The new wallet might be mining and reaping (solving the block itself).  If it didnt tithe, it cant receive pool rewards unless you copied the wallet (I hope no one is copying wallets in testnet however because that would really make it hard for us, we should all be using distinct wallets with distinct addresses and nicknames in testnet so we can reconcile everything).

The pog reward should only go to the TITHE address (its stored in the tithe), so you are probably referring to a mining reward.

To see what a tx is actually composed of just double click it in QT in the recieving list and look for the vout number.  A vout[0] means mining reward.  A vout[1] is usually masternode reward (or pool reward).  vout[2+] is a POG pool reward.



  • Rob Andrews
  • Administrator

    • 4090


    • 97
    • June 05, 2017, 08:09:04 PM
    • Patmos, Island Of
    more
Re: Testnet - Test Proof of Giving
« Reply #82 on: December 12, 2018, 04:11:01 PM »
1.1.6.4d-Mandatory Upgrade for TestNet

- Fixed bug in tithe inductor
- Add ability to force a tithe in (for people who want to donate to foundation regardless of diff) - the tithe doesnt count in the pool - this is in sendcoins UI
- Added exec istithelegal txid - Allows a user to verify a tithes legality - good for debugging purposes
- Modified exec tithe amount - To also accept just the amount.

Note that this version will disconnect older clients, so please, everyone upgrade.
Since this version considers a block before 1164 a bad block, we will need to do quite a bit of resyncing to agree, please lets check our blockhash.




  • Rob Andrews
  • Administrator

    • 4090


    • 97
    • June 05, 2017, 08:09:04 PM
    • Patmos, Island Of
    more
Re: Testnet - Test Proof of Giving
« Reply #83 on: December 12, 2018, 04:32:23 PM »
Makes sense Rob. Fro. The consumer side I'd prefer to Max tithe with very little change left over.  With the exec bankroll feature and some small change amounts, it may be a moot point.

Also, I'm confused by pog reward amounts.

One new wallet never tithed (too new) but I've been receiving pog rewards.

And then other times pog reward goes to non-tithe address. Is pog reward actually mined reward?


I was just looking at some of my POG rewards and I think I might know why you think some are mining that are POG.
First, if it says "POG REWARD" regardless of the amount it should be an actual POG.  The ones that say "MINED" are the reaper payments.

The confusing part:  If you are in a payment tier that pays 100%, that reaper reward is like 100 bbp and You as pog recipient get a massive amount, like 4000, making it look like a mining payment but it is really a pool payment.  This happens if that block didnt have a sanc payment on it.




  • Rob Andrews
  • Administrator

    • 4090


    • 97
    • June 05, 2017, 08:09:04 PM
    • Patmos, Island Of
    more
Re: Testnet - Test Proof of Giving
« Reply #84 on: December 12, 2018, 05:39:25 PM »
Question to the user who crashed, did you crash with 0 blocks in the chain?  If so I reproduced and fixed that in 1164, if not let us know how to reproduce.



  • MIP
  • Sr. Member

    • 365


    • 47
    • February 13, 2018, 11:55:52 AM
    more
Re: Testnet - Test Proof of Giving
« Reply #85 on: December 13, 2018, 03:15:14 AM »
1.1.6.4d-Mandatory Upgrade for TestNet

- Fixed bug in tithe inductor
- Add ability to force a tithe in (for people who want to donate to foundation regardless of diff) - the tithe doesnt count in the pool - this is in sendcoins UI
- Added exec istithelegal txid - Allows a user to verify a tithes legality - good for debugging purposes
- Modified exec tithe amount - To also accept just the amount.

Note that this version will disconnect older clients, so please, everyone upgrade.
Since this version considers a block before 1164 a bad block, we will need to do quite a bit of resyncing to agree, please lets check our blockhash.

Also ready in biblepay-official/testnet PPA for Linux and MacOS testnet URL (www.biblepay.org/biblepaycore-testnet.dmg)


  • Rob Andrews
  • Administrator

    • 4090


    • 97
    • June 05, 2017, 08:09:04 PM
    • Patmos, Island Of
    more
Re: Testnet - Test Proof of Giving
« Reply #86 on: December 13, 2018, 09:14:54 AM »
Please don't test this new version 1.1.6.4 - I found a bug.

Will need a new release.



  • Rob Andrews
  • Administrator

    • 4090


    • 97
    • June 05, 2017, 08:09:04 PM
    • Patmos, Island Of
    more
Re: Testnet - Test Proof of Giving
« Reply #87 on: December 13, 2018, 11:56:45 AM »
1.1.6.5 - Mandatory Upgrade for TestNet


The new version is ready.



  • Rob Andrews
  • Administrator

    • 4090


    • 97
    • June 05, 2017, 08:09:04 PM
    • Patmos, Island Of
    more
Re: Testnet - Test Proof of Giving
« Reply #88 on: December 13, 2018, 05:12:47 PM »
1.1.6.5 - Mandatory Upgrade for TestNet


The new version is ready.


Wait, I found yet another bug.

I'm sorry... It didnt reveal itself til I synced my 3rd node.

Please wait for the new testnet version again.



  • Rob Andrews
  • Administrator

    • 4090


    • 97
    • June 05, 2017, 08:09:04 PM
    • Patmos, Island Of
    more
Re: Testnet - Test Proof of Giving
« Reply #89 on: December 13, 2018, 09:30:38 PM »
1.1.6.6 - Mandatory Upgrade for TestNet


The new version is ready.